-
Notifications
You must be signed in to change notification settings - Fork 33
DOCSP-47019 Shift Go ToC #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: comp-cov
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-golang ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ToC is looking good so far! Left some comments for a few suggestions and fixes.
@@ -10,25 +10,29 @@ | |||
:description: Learn how to use the MongoDB Go Driver. | |||
:keywords: landing page, index | |||
|
|||
.. TODO cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[s] Maybe we can make a landing page ticket? Since the sections will need updates (e.g. remove "Fundamentals", rename some of the titles etc.)
================== | ||
Connection Options | ||
================== | ||
========================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[i] I think this file needs to be moved up one level so that this drawer shows up in the ToC
:titlesonly: | ||
:maxdepth: 1 | ||
|
||
Create a MongoClient <connect/mongoclient> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[i] I think that connection-targets
and connection-troubleshooting
can be added here?
=========== | ||
Connections | ||
=========== | ||
================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] Is this duplicative of the connect
page? Or meant to be something else?
Query Operations | ||
================ | ||
|
||
.. TODO Landing page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] Can we add the toctree for the Query drawer in this PR so it's visible in the ToC or are you thinking of a separate ticket that would include that work?
@@ -0,0 +1,23 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[s] Same as above.
@@ -0,0 +1,20 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[s] Add the ref at the top:
.. _golang-configure-crud: |
@@ -0,0 +1,34 @@ | |||
.. _golang-crud: | |||
|
|||
=============== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] I wasn't able to access this page when clicking on the CRUD Operations
title in the ToC, is that expected behavior?
@@ -0,0 +1,7 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[s] Made a few comments about adding the refs at the top, but I wasn't sure if this was intentional and planned to be added later 😅
@@ -0,0 +1,5 @@ | |||
.. _go-connection-targets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] What do you think, should we stick with golang
for all of these instead of go
? I'm not sure what the more highly used one is but maybe as we're adding new files we can keep the same naming system.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47019
Self-Review Checklist