Add Mongo builder mixin to DocumentModel
#3417
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It helps with autocompletion as IDEs will recognize Mongo builder methods that are not present on the base builder.
paulinevos
force-pushed
the
326_improve-type
branch
from
30d527a to
e93391b
Compare
GromNaN
reviewed
Jun 25, 2025
| @@ -50,6 +50,7 @@ | |||
| use function strlen; | |||
| use function var_export; | |||
|
|
|||
| /** @mixin Builder */ | |||
There was a problem hiding this comment.
I had to remove the @mixin annotation from the Model class (#2981) because the return types of the methods is not the same in the Builder and the Model. I must have made a mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps with autocompletion as IDEs will recognize Mongo builder methods that are not present on the base builder.
Checklist
Add tests and ensure they passN/A