Ensure socks5 proxy option parsing is to specification #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicates are not permitted, where as elsewhere in the connection string they are. JAVA-5834
rozza
requested review from
a team and
stIncMale
and removed request for
a team
stIncMale
requested changes
May 1, 2025
| @@ -1259,6 +1259,19 @@ private void validateProxyParameters() { | |||
| throw new IllegalArgumentException( | |||
| "Both proxyUsername and proxyPassword must be set together. They cannot be set individually"); | |||
| } | |||
|
|
|||
| if (proxyHost != null && optionsMap.get("proxyhost").size() > 1) { | |||
There was a problem hiding this comment.
proxyHost != null is used here (and similarly below) as a way to check that optionsMap.get("proxyhost") is not null. Let's not do that, because it is not only non-obvious, but also fragile. We may introduce a static method for checking that a null-able Collection has more than one element, which tolerates nulls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates are not permitted, where as elsewhere in the connection string they are.
JAVA-5834