Fix OIDC reauthentication when a session is involved #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
commented
May 27, 2025
Comment on lines
105
to
114
| public void reauthenticate(final InternalConnection connection, final OperationContext operationContext) { | ||
| authenticate(connection, connection.getDescription(), operationContext); | ||
| authenticate(connection, connection.getDescription(), operationContext.withSessionContext(NoOpSessionContext.INSTANCE)); | ||
| } | ||
|
|
||
| public void reauthenticateAsync(final InternalConnection connection, final OperationContext operationContext, | ||
| final SingleResultCallback<Void> callback) { | ||
| beginAsync().thenRun((c) -> { | ||
| authenticateAsync(connection, connection.getDescription(), operationContext, c); | ||
| authenticateAsync(connection, connection.getDescription(), operationContext.withSessionContext(NoOpSessionContext.INSTANCE), c); | ||
| }).finish(callback); | ||
| } |
There was a problem hiding this comment.
The OperationContext for the first authentication when we establish a connection comes from MongoClusterImpl.OperationExecutorImpl.getOperationContext, and does not have a SessionContext.
There was a problem hiding this comment.
The one difference is the use of ReadConcernAwareNoOpSessionContext instead of NoOpSessionContext. I doubt it matters, but I don't remember why that class was needed.
There was a problem hiding this comment.
Started using ReadConcernAwareNoOpSessionContext in df84c84 just in case.
jyemin
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is waiting for mongodb/specifications#1805.
JAVA-5880