fix: Fix foascli sunset list to print sunset endpoints with deterministic order
#804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
changed the title
foascli sunset list
andreaangiolillo
changed the title
foascli sunset listfoascli sunset list to print sunset endpoints with deterministic order
| return nil | ||
| keysContent := slices.Collect(maps.Keys(content)) | ||
| // Regex to find a date in YYYY-MM-DD format. | ||
| dateRegex := regexp.MustCompile(`\d{4}-\d{2}-\d{2}`) |
There was a problem hiding this comment.
q: What about upcoming and preview?
There was a problem hiding this comment.
upcoming will sunset with the related stable api so we will get the sunset date from the stable api.
Regarding preview is a bit tricky, I need to think about how to add support for it and if it makes sense 🤔
There was a problem hiding this comment.
I will create a follow up ticket for preview
jeroenvervaeke
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request introduces enhancements to the sunset listing functionality, including sorting improvements, additional test coverage, and updates to handle API content extensions. The changes aim to improve the accuracy and reliability of the sunset data processing and testing.
Enhancements to sunset listing functionality:
PathandOperationin ascending order to ensure consistent output. (tools/cli/internal/cli/sunset/list.go, tools/cli/internal/cli/sunset/list.goR56-R63)contentExtensionsfunction to sort API content by date using a regex and return the extensions of the earliest version. (tools/cli/internal/openapi/sunset/sunset.go, tools/cli/internal/openapi/sunset/sunset.goL98-R119)Testing improvements:
TestList_Runtest to include validation of output against expected results using JSON unmarshalling and deep equality checks. (tools/cli/internal/cli/sunset/list_test.go, tools/cli/internal/cli/sunset/list_test.goR34-R135)tools/cli/internal/cli/sunset/list_test.go, tools/cli/internal/cli/sunset/list_test.goR34-R135)