Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoongArch64 build support #3198

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Conversation

4Darmygeometry
Copy link

@4Darmygeometry 4Darmygeometry commented Mar 13, 2025

Description of Change

Add LoongArch64 build support, LoongArch64 is a new ISA Cored By Loongson Technology LLC.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • [√] Has tests (if omitted, state reason in description)
  • [√] Rebased on top of main at time of PR
  • [√] Merged related skia PRs
  • [√] Changes adhere to coding standard
  • [√] Updated documentation

Add loongarch64 build support
Add loongarch64 build support
Add loongarch64 build support
Add loongarch64 build support
Add loongarch64 build support
Add loongarch64 build support using Loongnix 25
Add loongarch64 build support
Add loongarch64 build support
Add loongarch64 build support
@4Darmygeometry

This comment was marked as outdated.

@kasperk81
Copy link
Contributor

it will be much easier to add this arch after #3200 goes in

@4Darmygeometry
Copy link
Author

it will be much easier to add this arch after #3200 goes in

Suggest adding RISC-V 64 and LoongArch64 simultaneously

@kasperk81
Copy link
Contributor

main change was in #3192, next is #3200 which makes both gnu and musl use the same clang cross script so x86_64 ci can build artifacts easily. once the second pr is merged, you can rebase and this pr will be very clean.

Suggest adding RISC-V 64 and LoongArch64 simultaneously

one benefit of keeping these changes separate is to track when things were added, with clean git history.

@4Darmygeometry
Copy link
Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 3198 in repo mono/SkiaSharp

@mattleibow
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@4Darmygeometry
Copy link
Author

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@Catty2014

@mattleibow
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@kasperk81
Copy link
Contributor

@mattleibow are you planning to merge this before #3200?

@kasperk81
Copy link
Contributor

i started this work before them and they are just piggybacking. the decent thing to do is to wait for my work to finish..

@mattleibow
Copy link
Contributor

I am not merging yet. I am just checking the build.
@4Darmygeometry can keep this open and rebase already on the PR by @kasperk81

Once we merge that, the diff will suddenly shrink.

fix loongarch64 docker build
Add LoongArch64 Alpine support
Add LoongArch64 Alpine support
Add LoongArch64 docker build support
Add LoongArch64 docker build support
@mattleibow mattleibow marked this pull request as draft March 14, 2025 12:55
Add LoongArch64 Alpine support
Add LoongArch64 docker build support
Add LoongArch64 Alpine support
Update LoongArch64 support
alpine fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[FEATURE] LoongArch64 flavor of libSkiaSharp and libHarfBuzzSharp
3 participants