Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Vulkan support in Skia on macOS #3203

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

sowa705
Copy link

@sowa705 sowa705 commented Mar 14, 2025

Description of Change

Enable Vulkan support in native library on MacOS

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

Copy link
Contributor

Hey there @sowa705! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sowa705
Copy link
Author

sowa705 commented Mar 14, 2025

Draft for now, I want to do some testing locally before publishing the PR as non-draft

@sowa705
Copy link
Author

sowa705 commented Mar 14, 2025

/azp run

Copy link

Commenter does not have sufficient privileges for PR 3203 in repo mono/SkiaSharp

@NicholasFreeman
Copy link

NicholasFreeman commented Mar 15, 2025

Draft for now, I want to do some testing locally before publishing the PR as non-draft

@sowa705
I am working on getting https://github.com/MrJul/Estragonia to work on Mac and, the lack on Vulkan support (in SkiaSharp) is a show stopper. But, wait! You are working to fix my exact problem. I have cloned your PR and am attempting to build the native bits buuuuut, I have no idea how to do that. I will continue Googling but, if you have some guidance, it would be greatly appreciated.

dotnet cake --target=<SOMETHING GOES HERE> --skipExternals=all --supportVulkan=true?

NM. I got it building. Working on testing now...

@sowa705
Copy link
Author

sowa705 commented Mar 15, 2025

I was able to build native skia libraries with vk enabled but the rest of the solution is giving me some issues

@NicholasFreeman
Copy link

I was able to build native skia libraries with vk enabled but the rest of the solution is giving me some issues

Same here. I patched your changes on to the latest production release (3.116.1) and it builds but, there is a crash in MoltenVK. I have tested several versions of MoltenVK, all have the same crash issue. I can post a stack trace shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Vulkan support on macOS
2 participants