-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added body to events removed introduction/conclusion and properly display events on the show page #138
Conversation
|
||
expect(rendered).to have_link "#{event.title}", href: event_path(event) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final newline missing.
factory :event do | ||
title "event title" | ||
body "event content" | ||
location |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace detected.
rebased and ready to merge |
Hey @itsWill -- thanks for putting this together. I wanted to get this merged in tonight but there's an error when running the migration from the start:
I know what the issue is, but a little tired now to think through a solution. Perhaps yourself or another contributor could take a look. Thanks! |
@@ -1,4 +1,8 @@ | |||
class CreateEvents < ActiveRecord::Migration | |||
class Event < ActiveRecord::Base | |||
translates :title, :introduction, :conclusion | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The globalize translations are introduced in this migration then later removed, this causes an error in the rake db:migrate
. This is a workaround to the issue @nicholasjhenry reported.
I added a work around to it, I managed to get it to work on my machine however without it, by doing a |
rebased, and ready to merge. |
@itsWill can you rebase again? :) |
assign(:events, [event]) | ||
render | ||
|
||
expect(rendered).to have_link "#{event.title}", href: event_path(event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer to_s
over string interpolation.
… events on index page
new -> #196 (that way I could commit on the branch) |
This fixes #106 and the outstanding tasks in #14
@nicholasjhenry