Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure email sender (see #250) to '[email protected]' #269

Closed
wants to merge 1 commit into from

Conversation

bellef
Copy link
Contributor

@bellef bellef commented May 15, 2017

Fix for #250
@sophiedeziel is it ok to put your email here?

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 98.438% when pulling 4119bf3 on bellef:fix/mailer_sender into b6b70a6 on montrealrb:master.

Copy link

@xymbol xymbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should never put actual email addresses in an open source project. Say someone rewrites a test and inadvertently sends 1,000 emails using that address?

@sophiedeziel
Copy link
Member

I think you should reopen that pull-request, but using an environment variable instead of a string. That way, it's a matter of configuration on the prod server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants