Enroloptions #14
Enroloptions #14
Conversation
|
@abias Are there problems with the travis.yml? It seems that it uses the wrong node version. Could you fix those problems?
But also the help text. Teachers will probably get confused if they get only offered a help text for the e-mail option, although they are only able to select for instance the username. |
|
Thanks, looks good to me now |
|
Thank you for this pull request!
@tobiasreischmann - Yes. Moodle core updated to a new node version in MDL-66109 and this had to be adopted in .travis.yml. See open-lms-open-source/moodle-plugin-ci#115 for details. @rtschu - Please rebase the PR onto this repo's latest master and Travis should work again. Beyond that, may I ask if your PR is already ready for review or if you are still working on Tobias' feedback? Cheers, |
sevenseas-gists
force-pushed
the
enroloptions
branch
from
47c8027 to
6e2af17
Compare
sevenseas-gists
force-pushed
the
enroloptions
branch
from
4fa24c1 to
bf9bf64
Compare
|
@abias Pull request is ready for review and has been rebased |
|
Hi, I use this pull request in a productive moodle. Works fine. |
| $string['error_usermails_empty'] = 'List of e-mail addresses is empty. Please add at least one e-mail address.'; | ||
| $string['error_check_is_already_member'] = 'Error checking if the user (<em>{$a->email}</em>) is already a member of group (<em>{$a->groupname}</em>). {$a->error}'; | ||
| $string['error_group_add_member'] = 'There was a problem when adding the user <em>{$a->data}</em> to the course group <em>{$a->group}</em>.'; | ||
| $string['error_more_than_one_record_for_data'] = 'More than one existing Moodle user account with {$a->field} <em>{$a->identifier}</em>em> found.<br /> This line will be ignored, none of the existing Moodle users will be enrolled.'; |
Lets Teachers choose different Fields then email to enrol users by.