Update app config to support Ionic 5 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelDeMartin
force-pushed
the
MOBILE-3738
branch
2 times, most recently
from
20b4893 to
8548510
Compare
|
Hi, just a side note about #161 , where we are planning to stop and remove Travis integration with this repository, now that we have it covered with GHA alternative. |
NoelDeMartin
force-pushed
the
MOBILE-3738
branch
5 times, most recently
from
28c1176 to
a395037
Compare
|
Thanks @stronk7, I've updated the config to include GHA tests as well. I've also updated the strategy to detect the runtime (ionic 3 or ionic 5), and it will be automatic most of the time. |
NoelDeMartin
force-pushed
the
MOBILE-3738
branch
from
a395037 to
39909be
Compare
NoelDeMartin
force-pushed
the
MOBILE-3738
branch
2 times, most recently
from
b3e9497 to
0f3e94e
Compare
NoelDeMartin
force-pushed
the
MOBILE-3738
branch
from
0f3e94e to
d830b6a
Compare
|
Merged, thanks, yay! PS: Only thing I found a little bit confusing is the tags thing, having next, dev, next-dev, latest, test, next-test... but surely it's because I'm not used to the different alternatives and the target of each one. The docs page seems to explain it pretty well, so all right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Apps Team, we've been working on migrating the mobile app to ionic 5.
Whilst doing that, there are some things affecting this repository that have changed. For example, the images on docker hub were previously bundling the source code and that's why it took them a while to get started. For ionic 5, we started bundling the compiled assets and the images are now a lot smaller and run a lot faster. As a side-effect of that, images are served on port 80. Other than that, some commands have changed slightly.
The mobile app with Ionic 5 hasn't been released yet, so I don't think this should be merged until that happens. But we can use this PR to discuss the approach and have everything ready for release day. That way, the day that the master branch in the mobile app repository becomes ionic 5, we can merge this and keep both repositories in sync.