-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA support to moodle-docker #159
Conversation
You can see it passing @ https://github.com/stronk7/moodle-docker/actions/runs/849100015 And the very-last commit (36fe4b0) that makes this PR is running @ https://github.com/stronk7/moodle-docker/actions/runs/849335063 Ciao :-) PS: Obviously... this PR only can run Travis tests, because GHA is not upstream, heh. ;-) |
Have amended the commit (4ce009b) to save setting up one variable... latest changes are being run now by Travis and https://github.com/stronk7/moodle-docker/actions/runs/849537749. Ciao :-) |
Basically does the same than old Travis runs, with some differences: - I've grouped the jobs into 3 categories (phpunit, behat, app). - Each one has own setup/teardown/test shell script, instead of the previous "mammoth" setup and test scripts, that I've left unmodified - Aiming to get the travis CI runs disabled because they are super slow (we only have 2 concurrent jobs allowed) and, while running, all the other moodlehq repos have to wait. - I'll create an issue to remove travis support once this is accepted and working ok. - Only change that I had to perform to existing stuff is raising the hardcoded sleep of 5 seconds to 10 seconds because I was getting some random failures with MySQL, needing more time to start. - We should move to proper health-checks for database (moodlehq#160) containers soon, much like app containers (moodlehq#131).
Whops, will try to fix it on next PR, thanks! |
GHA integration has been added recently: moodlehq#159 Jobs in this repo are a lot (of combinations) and they keep our travis busy for hours, not allowing other repos to advance. Plus, solve critical (:-P) typo in comment. This closes moodlehq#161
GHA integration has been added recently: moodlehq#159 Jobs in this repo are a lot (of combinations) and they keep our travis busy for hours, not allowing other repos to advance. Plus, solve critical (:-P) typo in comment. This closes moodlehq#161
GHA integration has been added recently: moodlehq#159 Jobs in this repo are a lot (of combinations) and they keep our travis busy for hours, not allowing other repos to advance. Plus, solve critical (:-P) typo in comment. This closes moodlehq#161
Basically does the same than old Travis runs, with some differences:
previous "mammoth" setup and test scripts, that I've left unmodified
(we only have 2 concurrent jobs allowed) and, while running, all the
other moodlehq repos have to wait.
is accepted and working ok.
hardcoded sleep of 5 seconds to 10 seconds because I was getting some
random failures with MySQL, needing more time to start.
much like app containers (Implement healthcheck for app development container #131).