Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA support to moodle-docker #159

Merged
merged 1 commit into from
May 17, 2021
Merged

Add GHA support to moodle-docker #159

merged 1 commit into from
May 17, 2021

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented May 17, 2021

Basically does the same than old Travis runs, with some differences:

  • I've grouped the jobs into 3 categories (phpunit, behat, app).
  • Each one has own setup/teardown/test shell script, instead of the
    previous "mammoth" setup and test scripts, that I've left unmodified
  • Aiming to get the travis CI runs disabled because they are super slow
    (we only have 2 concurrent jobs allowed) and, while running, all the
    other moodlehq repos have to wait.
  • I'll create an issue to remove travis support once this
    is accepted and working ok.
  • Only change that I had to perform to existing stuff is raising the
    hardcoded sleep of 5 seconds to 10 seconds because I was getting some
    random failures with MySQL, needing more time to start.
  • We should move to proper health-checks for database (Implement proper health-check for databases #160) containers soon,
    much like app containers (Implement healthcheck for app development container #131).

@stronk7
Copy link
Member Author

stronk7 commented May 17, 2021

You can see it passing @ https://github.com/stronk7/moodle-docker/actions/runs/849100015

And the very-last commit (36fe4b0) that makes this PR is running @ https://github.com/stronk7/moodle-docker/actions/runs/849335063

Ciao :-)

PS: Obviously... this PR only can run Travis tests, because GHA is not upstream, heh. ;-)

@stronk7
Copy link
Member Author

stronk7 commented May 17, 2021

Have amended the commit (4ce009b) to save setting up one variable... latest changes are being run now by Travis and https://github.com/stronk7/moodle-docker/actions/runs/849537749.

Ciao :-)

Basically does the same than old Travis runs, with some differences:

- I've grouped the jobs into 3 categories (phpunit, behat, app).
- Each one has own setup/teardown/test shell script, instead of the
  previous "mammoth" setup and test scripts, that I've left unmodified
- Aiming to get the travis CI runs disabled because they are super slow
  (we only have 2 concurrent jobs allowed) and, while running, all the
  other moodlehq repos have to wait.
- I'll create an issue to remove travis support once this
  is accepted and working ok.
- Only change that I had to perform to existing stuff is raising the
  hardcoded sleep of 5 seconds to 10 seconds because I was getting some
  random failures with MySQL, needing more time to start.
- We should move to proper health-checks for database (moodlehq#160) containers soon,
  much like app containers (moodlehq#131).
@vmdef
Copy link
Contributor

vmdef commented May 17, 2021

Thank you @stronk7. The structure is quite clear and the comment makes it even easier to understand the code. Only one minor typo that does not "matter".

@vmdef vmdef merged commit ddaf009 into moodlehq:master May 17, 2021
@stronk7
Copy link
Member Author

stronk7 commented May 18, 2021

minor typo that does not "matter".

Whops, will try to fix it on next PR, thanks!

@stronk7 stronk7 deleted the add_gha branch May 18, 2021 09:13
stronk7 added a commit to stronk7/moodle-docker that referenced this pull request May 18, 2021
GHA integration has been added recently: moodlehq#159

Jobs in this repo are a lot (of combinations)
and they keep our travis busy for hours, not
allowing other repos to advance.

Plus, solve critical (:-P) typo in comment.

This closes moodlehq#161
stronk7 added a commit to stronk7/moodle-docker that referenced this pull request Jun 23, 2021
GHA integration has been added recently: moodlehq#159

Jobs in this repo are a lot (of combinations)
and they keep our travis busy for hours, not
allowing other repos to advance.

Plus, solve critical (:-P) typo in comment.

This closes moodlehq#161
stronk7 added a commit to stronk7/moodle-docker that referenced this pull request Aug 2, 2021
GHA integration has been added recently: moodlehq#159

Jobs in this repo are a lot (of combinations)
and they keep our travis busy for hours, not
allowing other repos to advance.

Plus, solve critical (:-P) typo in comment.

This closes moodlehq#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants