Prepare app config for 4.4.0 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -debug suffix has been deprecated in selenium v4 images
The 4.4.0 release of the app changes some things that need to be updated in the Docker images. In particular, moving away from WebSQL (MOBILE-4304) introduced a requirement to run the application in a secure context; and the app will run with the https:// protocol on port 443 by default. The app also needs to run in a newer version of Chrome now; so when the app is being used it will default to version 120.0. These changes will be applied for the ionic7 runtime, which also changed in this release. This update to moodle-docker removes all the code related with the ionic3 runtime, which hasn't been used in the app since version 3.9.4 (December 2020). Given that this should work out of the box now, the documentation for the MOODLE_DOCKER_APP_RUNTIME and MOODLE_DOCKER_APP_NODE_VERSION variables has been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need to undo the last commit once the 4.4.0 app has been released, but I think it's better to get this integrated before the actual release to expedite the process.