Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Moodle 5.0 requirements for PHPUnit too #310

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Dec 2, 2024

This commit adds missing values in the phpunit matrix (missed in the last commit and raised by the GHA).

5.0 agreed environment requirements:

- PHP 8.2
- PostgreSQL 14
- MySQL 8.4
- MariaDB 10.11.0

Apart from this, the Moodle 4.5 branch has also been added to GHA.

This commit adds missing values in the phpunit matrix (missed in the last commit and raised by the GHA).

5.0 agreed environment requirements:

    - PHP 8.2
    - PostgreSQL 14
    - MySQL 8.4
    - MariaDB 10.11.0

Apart from this, the Moodle 4.5 branch has also been added to GHA.
@sarjona
Copy link
Member Author

sarjona commented Dec 3, 2024

Hi @paulholden!
Whenever you can, it would be great if you could also peer-review this (to increase requirements for the PHPUnit jobs too).
The app failure can be ignored because it's unrelated to the patch and Dani Palou from the apps team is looking at it ;-)

@paulholden paulholden merged commit 31affff into moodlehq:main Dec 3, 2024
139 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants