Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump php dependencies (and other minor tweaks) #336

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Jan 28, 2025

Bump a bunch of php dependencies to latest ones

Just update to current ones, automatically, without changing
any composer.json requirement.

Fixes #332 (and #333, just saw that one).

And, also, 3 more commits:

  • Re-generates the CLI docs which features were changed by Use general stylelint task in grunt command #320. <-- (just a detail)
  • Bump GHA to postgres 14, that is a requirement for Moodle 5.0. <-- (self tests)
  • Remove the PHPUnit --verbose option from Moodle >= 5.0 runs. <-- (impacting!)

Just update to current ones, automatically, without changing
any composer.json requirement.

Fixes moodlehq#332
This re-generates the CLI docs which features were changed by moodlehq#320
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (18fe3e1) to head (9ca8659).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/Command/PHPUnitCommand.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #336      +/-   ##
============================================
- Coverage     88.34%   88.30%   -0.04%     
- Complexity      757      760       +3     
============================================
  Files            77       77              
  Lines          2333     2334       +1     
============================================
  Hits           2061     2061              
- Misses          272      273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7 stronk7 force-pushed the bump_php_dependencies branch from 56bf1f5 to b73c012 Compare January 28, 2025 10:34
Also, within GH workflows, emit a warning about it being removed.
@stronk7 stronk7 force-pushed the bump_php_dependencies branch from b73c012 to 9ca8659 Compare January 28, 2025 10:36
Copy link
Member

@kabalin kabalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stronk7 for housekeeping!

@kabalin kabalin merged commit 16d9a92 into moodlehq:main Jan 31, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants