Use atomic variables for ConnectionInterrupted and LBQ currentSize #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hese were the only two variables reported by clang's -fsanitize=thread
|
Yeah, I tried a while back to make this code TSan clean. Unfortunately we will run into the fact that C11 atomics aren't well supported on MSVC. Last I saw, they are supported with only an experimental compiler flag ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the only two variables reported by clang's -fsanitize=thread. I was testing the iOS app in Xcode and didn't test that many code paths, but these 2 were straightforward to fix.
For as often as currentSize gets touched, it's never caused a problem for me, so I doubt these have ever caused crashes for anyone. Maybe technically, in theory they could have.