Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a look and leave comments on things you don't get :) #1

Merged
merged 12 commits into from
Nov 24, 2014

Conversation

neanias
Copy link
Contributor

@neanias neanias commented Nov 24, 2014

No description provided.

* feature/cleanup:
  Better in an if..else than unless for token checking
  Using Sinatra's actual methods for errors
  Actual exist check for names
  Moved some whitespace for readability
  I'm not even sure how that worked before...
  Changed some spelling
  Ran `bundle`
  Stripped trailing whitespace
  Added thin to the Gemfile
  Use '' when not interpolating
  Updated hash syntax
@neanias
Copy link
Contributor Author

neanias commented Nov 24, 2014

Since ruby 1.9, there's a new syntax for hashes with symbols as keys which ditches the hash rocket and is more like Python or JS: {:key => 'value'} to {key: 'value'}. But the hash rockets still apply for string based keys: {'key' => 'value'}.

It's generally best to use symbols as keys in hashes since they're immutable (I think that's the reason...)

moredhel pushed a commit that referenced this pull request Nov 24, 2014
Have a look and leave comments on things you don't get :)
@moredhel moredhel merged commit 33e2b5d into moredhel:master Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants