Skip to content

Commit

Permalink
Refactoring lib/schedule_events.js (#395)
Browse files Browse the repository at this point in the history
* Use reject in schedule_events.js

* Modify to omit parentheses in schedule_events.js
  • Loading branch information
abetomo authored and DeviaVir committed Dec 11, 2017
1 parent 112c2f6 commit c764b61
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions lib/schedule_events.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ class ScheduleEvents {

_putRule (params) {
// return RuleArn if created
return new Promise((resolve) => {
return new Promise((resolve, reject) => {
const _params = this._putRulePrams(params)
this.cloudwatchevents.putRule(_params, (err, rule) => {
if (err) throw err
if (err) reject(err)
resolve(rule)
})
})
Expand All @@ -53,11 +53,11 @@ class ScheduleEvents {
}

_addPermission (params) {
return new Promise((resolve) => {
return new Promise((resolve, reject) => {
const _params = this._addPermissionParams(params)
this.lambda.addPermission(_params, (err, data) => {
if (err) {
if (err.code !== 'ResourceConflictException') throw err
if (err.code !== 'ResourceConflictException') reject(err)
// If it exists it will result in an error but there is no problem.
resolve('Permission already set')
}
Expand All @@ -78,11 +78,11 @@ class ScheduleEvents {
}

_putTargets (params) {
return new Promise((resolve) => {
return new Promise((resolve, reject) => {
const _params = this._putTargetsParams(params)
this.cloudwatchevents.putTargets(_params, (err, data) => {
// even if it is already registered, it will not be an error.
if (err) throw (err)
if (err) reject(err)
resolve(data)
})
})
Expand All @@ -91,9 +91,9 @@ class ScheduleEvents {
add (params) {
return Promise.resolve().then(() => {
return this._putRule(params)
}).then((rule) => {
}).then(rule => {
return this._addPermission(Object.assign(params, rule))
}).then((data) => {
}).then(data => {
return this._putTargets(params)
})
}
Expand Down

0 comments on commit c764b61

Please sign in to comment.