-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version and origin URL to binary and generated sources #131
base: vlm_master
Are you sure you want to change the base?
Conversation
@mouse07410 this is my first PR, let's start by distinguishing the version we are using... should adjust automatically for any fork cloned via git. |
Certainly. First, welcome in!
Yes. My apologies for delay in getting to this - other things piled up. Let's see what the CI has to say. I suspect we (you ;-) would need to do more changes, as I seem to recall that ASN.1 compiler version is hard-coded in the tests (rather unfortunate, but I "inherited" this vast body of tests from the upstream).
Absolutely! Update@gatopeich if you could take a look at the tests and why they fail? E.g., run Update 2Please merge the current |
@gatopeich could you please try to address the CI failure in your PR? |
I haven't forgotten, will do it on next chance |
Hey guys. I agree, this is a very useful feature.
I suggest keeping some sort of incremental versioning (like SemVer), as package systems usually rely on an incremental system to correctly do updates. |
Standing by for a PR that provides the necessary functionality and passes CI. 😉 |
Standing by for updates to this PR that resolves conflicts and passes CI. |
I hear you 🙂 |
asn1c identifies itself and its generated sources with the latest release/tag name, commit hash, and date of the last commit.
Also shows the URL from
git remote get-url origin
so it is easy to trace it back to the specific fork that was used.And in the C sources: