Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggp fund without fee e2e #1004

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

ggp fund without fee e2e #1004

wants to merge 11 commits into from

Conversation

Icarus131
Copy link
Contributor

@Icarus131 Icarus131 commented Jan 16, 2025 •
edited
Loading

Summary

Refer to issue #984

Changelog

  • Added e2e test to ensure beneficiary of testnet governed_gas_pool::fund WILL receive their funds without any fees.

Testing

Use the following command to run the test:

RUSTC_LOG=info CELESTIA_LOG_LEVEL=FATAL CARGO_PROFILE=release CARGO_PROFILE_FLAGS=--release nix develop --extra-experimental-features nix-command --extra-experimental-features flakes --command bash -c "just movement-full-node native build.setup.eth-local.celestia-local.test-ggp-gas-fund-fee --keep-project"

@Icarus131 Icarus131 marked this pull request as ready for review January 21, 2025 22:01
0xmovses
0xmovses requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@0xmovses 0xmovses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this test to the Checks.yml so that it runs in our CI? thanks

@0xmovses
Copy link
Contributor

0xmovses commented Feb 6, 2025

And a conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmovses 0xmovses 0xmovses requested changes

@l-monninger l-monninger Awaiting requested review from l-monninger l-monninger is a code owner

@mzabaluev mzabaluev Awaiting requested review from mzabaluev mzabaluev is a code owner

@musitdev musitdev Awaiting requested review from musitdev musitdev is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cicd:governed-gas-pool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icarus131 @0xmovses