Test Mint and Burn

[Primata]

Summary

• RFCs: Link to RFC, Link to RFC, or $\emptyset$.
• Categories: any of protocol-units, networks, scripts, util, cicd, or misc.

#1009

Burn elsa's supply.

Changelog

moved away from native_bridge integration to e2e testing

added burn_from and mint_to methods gated to framework signer

Testing

networks/movement/movement-client/src/bin/e2e/lock_mint.rs

rm -rf .movement/ && RUST_LOG=info CELESTIA_LOG_LEVEL=FATAL CARGO_PROFILE=release CARGO_PROFILE_FLAGS=--release nix develop --extra-experimental-features nix-command --extra-experimental-features flakes --command bash -c "just movement-full-node native build.setup.eth-local.celestia-local.test-mint-burn --keep-tui"

Outstanding issues

We might need to add a burn_from entry function on the core_resources_account.

[0xmovses]

We all try to stick to this commit message standard (roughly)
https://www.conventionalcommits.org/en/v1.0.0/

[andygolay]

When I run

RUST_LOG=info CELESTIA_LOG_LEVEL=FATAL CARGO_PROFILE=release CARGO_PROFILE_FLAGS=--release nix develop --extra-experimental-features nix-command --extra-experimental-features flakes --command bash -c "just movement-full-node native build.setup.eth-local.celestia-local.test-lock-mint --keep-tui"

I get

Error: Failed to create dead account

caused by

API error Error(VmError): Invalid transaction: Type: Validation Code: SEQUENCE_NUMBER_TOO_OLD

[Primata]

When I run

RUST_LOG=info CELESTIA_LOG_LEVEL=FATAL CARGO_PROFILE=release CARGO_PROFILE_FLAGS=--release nix develop --extra-experimental-features nix-command --extra-experimental-features flakes --command bash -c "just movement-full-node native build.setup.eth-local.celestia-local.test-lock-mint --keep-tui"

I get

Error: Failed to create dead account

caused by

API error Error(VmError): Invalid transaction: Type: Validation Code: SEQUENCE_NUMBER_TOO_OLD

@andygolay please clear .movement/ before every run.

Updated command to do it before hand

[0xmovses]

As far I can see there is no NativeBridge.sol deployment on anvil here, and MOVE deposit call. @andygolay not ready for review yet.

[0xmovses]

Thanks for this. Remove all println!s for tracing::info. Cleanup imports, use tree style imports. The comments you've written right at the bottom are correct but lets remove the comment from the SC. Rename the test to mint_burn.rs and any associated process_compose naming and cmd / pkgs.

Thanks!

[0xmovses]

Merge conflicts will auto-resolve after:

1. Governed Gas Pool aptos-core#114 (review) is approved and merged
2. PR updates movement/main aptos deps to use branch = movement

[andygolay]

LGTM

[andygolay]

Added one change suggestion, to assert dead address balance is 0 at the end.

[0xmovses]

Even when I remove .movement/ here I get the error

Error: Failed to create dead account

Caused by:
    API error Error(VmError): Invalid transaction: Type: Validation Code: SEQUENCE_NUMBER_TOO_OLD

Wrong increment?

[0xmovses]

Is there a new dependent PR in aptos-core that contains the mint_to function? O

[Primata]

Is there a new dependent PR in aptos-core that contains the mint_to function? O

Same branch and PR add_burn_from

[0xmovses]

PR number or link?

[0xmovses]

Ok this is ready to go in can you fix the merge conflicts and add this test to the Checks.yml all new e2e test should be added to CI.

[l-monninger]

Will pull again.