Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: movement-full-node-v0.0.1-beta #1039

Conversation

l-monninger
Copy link
Collaborator

@l-monninger l-monninger commented Feb 7, 2025

Summary

  • RFCs: $\emptyset$.
  • Categories: protocol-units

The secondary tag used for onboarding to and test the Movement Full Node w/ secure signing, governed gas pool, and additional admin utilities.

Changelog

Testing

Outstanding issues

@cshein45
Copy link

cshein45 commented Feb 7, 2025

MOVE

@cshein45 cshein45 mentioned this pull request Feb 7, 2025
@0xmovses
Copy link
Contributor

We need to get this into main asap, there are several other PRs that rely on this. We are going with a release tag strategy, rather than release branch (avoid long living branches) as recommended by @radupopa369 and @nicolaslpf.

We need description in this PR and testing steps, also there are a tonne of conflicts.

@nicolaslpf
Copy link

Wrong nick i guess you might want to ping @mcmillennick

@0xmovses
Copy link
Contributor

Myself and @musitdev will take on the load of resolving conflicts, but if you could write some description and testing steps in the description would be great. We have already tagged main with this release, but actually the release is on this feature branch. This was done to meet the release deadline, let's fix now. @l-monninger drop anything useful in comments myself of Philippe should know about.

@l-monninger
Copy link
Collaborator Author

Yeah, not sure what happened here...

commit 3cb234fdacef3158f9f78f6bb90afef1024f6a96 (HEAD -> l-monninger/movement-full-node-v0.0.1-beta, origin/l-monninger/movement-full-node-v0.0.1-beta)
Author: Liam Monninger <[email protected]>
Date:   Tue Feb 11 08:00:54 2025 -0800

    fix: debugging migration script.

commit 61340ba855aa712d02eb612fb863cb3c71e9134f
Author: Liam Monninger <[email protected]>
Date:   Tue Feb 11 07:47:40 2025 -0800

    fix: bad naming.

commit 192d49970b90de00ecf0e982837ef65b4bd0f8f5
Author: Liam Monninger <[email protected]>
Date:   Tue Feb 11 07:46:56 2025 -0800

    fix: bad naming.

commit dac43bf56861e9d8a7dc2a33c2f1ee9557db0864
Author: Liam Monninger <[email protected]>
Date:   Thu Feb 6 21:50:21 2025 -0800

    fix: networks.

commit ee3d7f5ad434bfc94842b3251aeb788aaad70b6c
Author: Liam Monninger <[email protected]>
Date:   Thu Feb 6 19:27:48 2025 -0800

    feat: reintegrate signer into cli.

commit 5909d92e13ac7141e5cee41f3aea2b97e1255729
Author: Liam Monninger <[email protected]>
Date:   Thu Feb 6 19:25:59 2025 -0800

    fix: load key rotation signer.

commit 22a59877255a982596b3b1f648fb73e8afbe0dd3
Author: Liam Monninger <[email protected]>
Date:   Thu Feb 6 19:11:57 2025 -0800

    feat: update core resource account rotation abstraction.

commit 735d2c8569b83eeccbf27aa62583586c7f99d3bc
Author: Liam Monninger <[email protected]>
Date:   Thu Feb 6 18:02:10 2025 -0800

    fix: key rotation signer.

commit dd055fb32b480926adbd0e7d3a22d6cdfe489bd3
Author: Liam Monninger <[email protected]>
Date:   Thu Feb 6 17:56:45 2025 -0800

    fix: key-rotation.

commit d8057ed187c0f7598eb24ea38015e9db6c3effd1
Author: Liam Monninger <[email protected]>
Date:   Thu Feb 6 10:25:27 2025 -0800

    fix: hash specified mrb.

commit 72b65edb74d554424590e59884b40a607064fb8a
Author: Liam Monninger <[email protected]>
Date:   Thu Feb 6 10:15:31 2025 -0800

    fix: cleanup.

Date:   Wed Feb 5 17:36:13 2025 -0800

    fix: upgrade.

commit de20e4992861af0ce561e75a506740fa19f26bb8 (tag: movement-full-node-v0.0.1-alpha, origin/l-monninger/secure-signing-e2e-integration, l-monninger/secure-signing-e2e-integration)
Author: Liam Monninger <[email protected]>
Date:   Wed Feb 5 08:48:42 2025 -0800

    fix: merge.

@l-monninger
Copy link
Collaborator Author

Just going to try pulling locally.

@l-monninger
Copy link
Collaborator Author

Does not resolve.

@l-monninger
Copy link
Collaborator Author

I wonder if it has something to do with squashing.

@0xmovses
Copy link
Contributor

Never seen it occur with squashing before. Are the changes from 993 even in main?

The .debug/ is certainly there (which shouldn't be committed)
37d3b40

cc @elliottdehn this commit is where the .debug/ came from.

@l-monninger l-monninger changed the base branch from main to l-monninger/secure-signing-e2e-integration February 11, 2025 18:10
@l-monninger l-monninger merged commit e737faa into l-monninger/secure-signing-e2e-integration Feb 11, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants