Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1862316 - Update Thunderbird logo #2137

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Bug 1862316 - Update Thunderbird logo #2137

merged 1 commit into from
Nov 3, 2023

Conversation

dklawren
Copy link
Collaborator

@dklawren dklawren commented Nov 2, 2023

Updated thunderbird logo to newer logo.

@dklawren dklawren requested a review from cgsheeh November 2, 2023 22:28
cgsheeh
cgsheeh approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@cgsheeh cgsheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The new image is 1024x1024 whereas the old one was 128x128, that won't be a problem I assume?

@dklawren
Copy link
Collaborator Author

dklawren commented Nov 3, 2023

Nice! The new image is 1024x1024 whereas the old one was 128x128, that won't be a problem I assume?

Should be fine. The html that use the image is <img src="[% basepath FILTER none %]extensions/BMO/web/producticons/[% icon FILTER uri %]" height="64" width="64"> so all of the icons will look the same size.

@dklawren dklawren merged commit b796adc into mozilla-bteam:master Nov 3, 2023
7 checks passed
@dklawren dklawren deleted the 1862316 branch November 3, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgsheeh cgsheeh cgsheeh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dklawren @cgsheeh