Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1904321 - Make more user-facing pages mobile friendly #2334

Merged
merged 15 commits into from
Oct 28, 2024

Conversation

kyoshino
Copy link
Collaborator

@kyoshino kyoshino commented Oct 2, 2024

Bug 1904321 - Make more user-facing pages mobile friendly

  • Compact, fixed global header with mobile drawer navigation
    • Larger menu items on mobile for easier tapping
    • Minor UI refresh: new icons, menu padding
    • My Attention link is moved to the BMO extension
    • New Account and Forgot Password links are moved to Log In dropdown
  • Responsive page layout: Home, Log In, New Account, Browse, User Preferences
    • Log In page gets a cleaner design
    • Removed the legacy mobile CSS for the Log In page
    • Some tables in the prefs pages are too big and simply overflow

@kyoshino kyoshino marked this pull request as draft October 2, 2024 05:29
@kyoshino kyoshino marked this pull request as ready for review October 12, 2024 02:22
@dklawren dklawren self-requested a review October 17, 2024 14:36
Copy link
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the header icons and maybe the text a little brighter. They are difficult to see (at least for me). Also the text 'Search Bugs' placeholder text is too dim for me.This is true for both light and dark modes.
image

Also when in responsive mode, and touch simulation is on, the calendar widget will not work properly. For example, the reminder preference panel. You can see if by turning the simulation on/off and trying to enter a date in the calendar field.
image

Overall it looks very good. I will put this version on bugzilla-dev for feedback. A lot of the old legacy tables (admin pages, dashboard, etc,) are still awkward viewing on mobile but as long as you can scroll sideways to see the full data, it is not a showstopper for now.

@dklawren
Copy link
Collaborator

Please make the header icons and maybe the text a little brighter. They are difficult to see (at least for me). Also the text 'Search Bugs' placeholder text is too dim for me.This is true for both light and dark modes. image

Another example is the current header for BMO
image

The text and icons are brighter to me on production. The 'Search Bug' placeholder text is the same so not a regression but would be nice if we could make that more readable as well in the process.

@kyoshino kyoshino requested a review from dklawren October 28, 2024 03:56
@kyoshino
Copy link
Collaborator Author

Refined the header/drawer design as per feedback! The calendar not showing up seems to be a Firefox bug 😅

Copy link
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am sure users will see something i might have missed but with my testing it all works as expected. r=dkl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants