POC Unified Chrome Management #3311
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulsainani
force-pushed
the
unified-chrome-management-poc
branch
from
0a26dda to
bf331b7
Compare
rahulsainani
force-pushed
the
unified-chrome-management-poc
branch
from
bf331b7 to
a94c627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How
– Based on the proposal.
– Add
MainContainerFragment. Move chrome related "features" fromBrowserFragmenttoMainContainerFragment.– Add
HomeFragment.–
HomeFragmentandBrowserFragmentare children of theMainContainerFragment. One of those are navigated to using the nav graph based on the selected tab.– Add mechanisms to share state between parent and child fragments using
MainContainerViewModel. Showcase how the parent fragment can share info about the chrome position and how child fragment views (e.g. find in page UI) can use that. Similarly views on HomeFragment .– ExternalBrowser uses a different layout with the UI elements it needs - find in page, toolbar, engine view and the same coordinator layout behaviour setup.
– Setup specific external browser features in ExternalBrowserFragment
Feedback
– Please focus on the idea and the POC and not on the nits.
– I'd really appreciate if folks can highlight some edge cases and share solutions along with the questions too :)