Drop invalid packets to deal with moby/libnetwork#1090 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a fix for web-platform-tests/wpt#21529 as suggested by @Hexcles in linking to moby/libnetwork#1090
Baked an image from this and tried the repro steps for a while and it appeared to work.
Not too worried that this will cause other issues, seems pretty safe.
We can test this image in the tc workers for a bit and then roll it out everywhere or just
send it everywhere. I'd still like to do some of the other image cleanup work
we did to try to fix this before. It can wait until after the baremetal work lands though.