support uploading translations artifacts #1141
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
added a commit
to bhearsum/scriptworker-scripts
that referenced
this pull request
Feb 27, 2025
This is needed to support work from mozilla-releng#1141 where we're uploading all artifacts from upstream tasks, and can't reasonably predict all possible file types and extensions. This also fixes a minor bug in the `upload_to_s3` tests, where they implicitly rely on `setup_mimetypes()` being called elsewhere to pass (which means they fail mysteriously if run independently).
bhearsum
added a commit
to bhearsum/scriptworker-scripts
that referenced
this pull request
Feb 27, 2025
This is needed to support work from mozilla-releng#1141 where we're uploading all artifacts from upstream tasks, and can't reasonably predict all possible file types and extensions. This also fixes a minor bug in the `upload_to_s3` tests, where they implicitly rely on `setup_mimetypes()` being called elsewhere to pass (which means they fail mysteriously if run independently).
bhearsum
added a commit
that referenced
this pull request
Feb 28, 2025
This is needed to support work from #1141 where we're uploading all artifacts from upstream tasks, and can't reasonably predict all possible file types and extensions. This also fixes a minor bug in the `upload_to_s3` tests, where they implicitly rely on `setup_mimetypes()` being called elsewhere to pass (which means they fail mysteriously if run independently).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to mozilla/translations#590, mozilla/translations#466 - still very much a work in progress.