Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external table deployment in stage #6988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

Fix external table deployment in stage #6988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions bigquery_etl/deploy.py
View file
Original file line number Diff line number Diff line change
@@ -53,15 +53,16 @@ def deploy_table(
metadata = Metadata.of_query_file(artifact_file)

if metadata.external_data:
# We generate stub query.py sripts for external tables in stage, so this needs to be the first check
if skip_external_data:
raise SkippedExternalDataException(
f"Skipping deploy of external data table {artifact_file}"
)
if artifact_file.suffix == ".sql" or artifact_file.name == "query.py":
raise FailedDeployException(
f"Invalid metadata: {artifact_file} has both a SQL file and "
f"external data config"
)
if skip_external_data:
raise SkippedExternalDataException(
f"Skipping deploy of external data table {artifact_file}"
)

if (
metadata.scheduling