Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Note that reporting percentage needs rate limiting middleware #256

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Jan 20, 2025

Resolves #232

This seems to be the only occurrence not mentioning it already.

(Also removes some empty links from toc boilerplate & updates copyright to strftime placeholder.)

NB: The %Y placeholder was added in 8.1 and the pipelines currently run 8.1.3 (we don't pin a version) so this is hunky-dory in prod, but might be a little surprising if run in older envs that resolve 7.x for compatibility. I did not make this a conf needs_sphinx constraint to just not fail in such cases over a simple copyright string, but… caveat emptor.

Preview: https://janbrasna.github.io/django-csp/configuration.html#policy-settings

Copy link
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tidying up @janbrasna! r+

@stevejalim stevejalim merged commit 948a07b into mozilla:main Jan 20, 2025
8 checks passed
@janbrasna janbrasna deleted the upd/reporting-docs branch January 20, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Add that REPORT_PERCENTAGE requires the rate-limiting middleware in the configuration docs
2 participants