Implement TCP and UDP sockets in parent process #108
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
TCPSocket
andUDPSocket
implements run in the extension child process. This is fine for debugging, but we found that when running in a release browser with the process sandbox enabled then this process was blocked from opening sockets on Mac and Linux, meaning the APIs did not work.This PR fixes this issue by implementing both
TCPSocket
andUDPSocket
APIs in the parent process. The API exposed by the child to the extension has not changed, but now everything is shipped up to the parent, which then pushes data back to the child.