This repository has been archived by the owner on Feb 21, 2019. It is now read-only.
Send siteLogo for Persona popup as data-URI. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siteLogo must be served over HTTPS for the Persona popup, otherwise it causes an error. If you don’t have HTTPS set up in your local dev environment, you can’t log in. You can get around this by sending the siteLogo as a data-URI, which works regardless of protocol.
|
Oh yea. I forgot that I'd gotten around this by setting browserid options in my local.py that didn't include the logo. This is better. Thanks! |
|
Was this pushed @pmclanahan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't login on my dev instance due to this bug, so I decided to copy over the fix I applied to Affiliates. It seems to work fine.
siteLogo must be served over HTTPS for the Persona popup, otherwise it
causes an error. If you don’t have HTTPS set up in your local dev
environment, you can’t log in.
You can get around this by sending the siteLogo as a data-URI, which
works regardless of protocol.