Skip to content

fix: Update Reload Manager Extension for Chromium to MV3 #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hibi-10000
Copy link

Related to #3388

Upgrade web-ext Reload Manager Extension to Manifest Version 3 to prevent it from being disabled by Chromium-based browsers.

image

@Rob--W Rob--W self-requested a review April 6, 2025 18:44
@Rob--W
Copy link
Member

Rob--W commented Apr 6, 2025

Thanks for the PR. I am not merging this yet because there is other necessary work required to maintain long term support for Chromium browsers (#3388).

I had already noticed this issue before, but haven't migrated yet. It is not as trivial as bumping the manifest version + background property: In MV2, the background page is persistent, while in MV3 the background service worker may suspend on inactivity, which would break the WebSocket connection.

@Hibi-10000
Copy link
Author

For your information, it seemed to work fine, at least when I tested it by running it for a short time.
(In fact, I confirmed that it is able to receive information via WebSocket.)
Of course, I suppose it would need to be tested with it running for a longer period of time.

@unmade-spangle
Copy link

Thanks for the PR. I am not merging this yet because there is other necessary work required to maintain long term support for Chromium browsers (#3388).

I had already noticed this issue before, but haven't migrated yet. It is not as trivial as bumping the manifest version + background property: In MV2, the background page is persistent, while in MV3 the background service worker may suspend on inactivity, which would break the WebSocket connection.

Thanks. I believe you can incorporate a self-ping to keep it alive, @plasmohq/persistent/background has this implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants