simplify navigation menu links #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelFQC
requested changes
Jul 3, 2020
| @@ -13,7 +13,7 @@ | |||
| <ul class="navbar-nav mr-auto"> | |||
| {% for item in site.data.navigation %} | |||
| <li class="nav-item {% if page.url == item.link %}active{% endif %}"> | |||
| <a class="nav-link" href="{% if item.external %}{{ item.link }}{% else %}{{ site.url|append: item.link }}{% endif %}"> | |||
| <a class="nav-link" href="{{ item.link }}"> | |||
There was a problem hiding this comment.
He tenido problemas con jekyll para mostrar las rutas del mismo dominio, por eso uso site.url.
Estoy pensando en mover todo a GatsbyJS.
There was a problem hiding this comment.
Uhmm .. que tipo de problemas habia?
Tal vez habria que implementar algun tipo de staging en cada PR para probar los cambios de manera mas sencilla.
Lo de moverlo a Gatsby, la verdad que no lo he utilizado; pero por mi no hay problema. De paso se podria aprovechar para mejorar un poco el diseño de la web.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifica los links del menu