Added Ogg recording functions and variables. #2
Conversation
end recorder handler. Added class constructor.
|
Thanks for your input. I am just now getting to review it and have a few questions. Are you using a MP3 shield directly coupled to your Teensy? Or are you using jumper wires to mate the two? a. My concern with merging this aspect of the pull request; is that the wire jumpers between your Teensy and the your MP3 shield may and will likely be different for other implementers. I have already seen a few discussions about the Teensy, each having different SFEMP3ShieldConfig.h. I had initially thought your implementation was using Gravitech's Nano MP3 Shield, as it is similar form factor. However, upon further inspection, I find its pins require significant jumping. I myself have made several custom SFEMP3ShieldConfig.h files locally for the various creations. Though, none for the Teensy. I have not committed these eccentric files requiring special jumpers, as such commits have been reserved for configuration that lend themselves directly to available off the shelf shields, that don't require customization. As to make their implementation straightforward About Recording. I got a Geeetech boad with a MIC and Line Input. Did you use this? Or did you make your own Shield for Input? b. I do appear to be recording. But play back is way too small to hear. Only heard on playing back on PC. c. After using the GAIN increase I could. But there was a lot of junk on the line. d. Was it your intention that the Gain be only settable while recording? Seems like you would want to set it prior. e. Were you using something else (then the Geeetech Mic) and line volume was not a problem. I notice the VS_LINE1_MODE commented out. Indicating a MIC. Strange, when I use LINE and the original demo code with the ADMixerLoad enabled on the geeetech board I get pass through, just fine. But I don’t when attempting to use the record library Really feels, like something with GAIN and Volume. Any insight would be appreciated. Michael P. Flaga, mailto:[email protected] [email protected] From: miguelmoreto [mailto:[email protected]] I added several new methods and a constructor. You can merge this Pull Request by running git pull https://github.com/miguelmoreto/Sparkfun-MP3-Player-Shield-Arduino-Library master Or view, comment on, or merge it at: Commit Summary
File Changes
Patch Links: |
|
Hello Michael, I am quite busy this week because of my courses at university so I cannot respond all your questions until next week. I am not using gravitech, I am using this board: http://www.ebay.com/itm/VS1053-module-MP3-development-board-on-board-recording-function-/370668455831?pt=LH_DefaultDomain_0&hash=item564d8fc797 mounted on a universal board and connected with teensy by soldered wires. Best regards, Miguel |
I added several new methods and a constructor.
There is also a demo sketch to test the new functions.
Added support for Teensy2.0++ board in SFEMP3ShieldConfig.h