SW-3537 laserhead none will crash plugin #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Bug SW-3537 · laserhead None will crash Plugin |
irlaec
suggested changes
Sep 18, 2023
irlaec
previously approved these changes
Sep 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
irlaec
approved these changes
Sep 18, 2023
Josef-MrBeam
deleted the
bugfix/SW-3537-laserhead-none-will-crash-plugin
branch
irlaec
added a commit
that referenced
this pull request
Oct 6, 2023
#1814) * SW-3833 fix 1027 error (#1798) * improve error handling for fan pcb * only report hardware malfunction for fan stuff once and don't flood the log * dimiss notifications * don't cancel laser job on fan not spinning error only pause it and only report the errors if they appear outside the boot grace periode * SW-3537 fix laserhead none will crash plugin (#1800) * prevent recursive log calls * fix race condition for failing test * SW-3537 improve recursive log prevention (#1801) improve recursive log prevention * SW-3833 fix bug in logic (#1802) * SW-3915 fix final dust extraction phase 1 not working (#1808) * SW-3291 Quick text fonts are not loaded causing bounding box discrepancies (#1806) * SW-3291 Update cluster if it includes quickText elements * SW-3291 Refactor url2png and redraw canvas if url contains quickText elements * SW-3291 Refactor render-fills.js * SW-3291 Handle caught error * SW-3291 Add quickText font load timeout as a constant * SW-3291 Add includesQuickText parameter to all generatePNGFromURL methods used on QuickText elements * SW-3291 Add log messages on draw and clear canvas * SW-3291 Fix comments * SW-3291 Fix comments * SW-3291 Fix unneeded log variable * SW-3291 Add to analytics on issue detection * Revert "SW-3291 Add to analytics on issue detection" This reverts commit 45d1610. * SW-3291 Add Todo comment * SW-3291 Fix typo * First version * Revert "Merge branch 'alpha' into SW-3812-frontend-refresh-the-web-page-if-the-laser-cutter-mode-flips" This reverts commit 1a8688a, reversing changes made to e26217b. * Switch to using laser cutter mode string instead of id * Fix log --------- Co-authored-by: Josef-MrBeam <[email protected]> Co-authored-by: khaledsherkawi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent recursive log calls