Correcting some issues with vivax liver stage prophylaxis. #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RJSheppard
commented
Mar 19, 2025
RJSheppard
commented
- ls_drug and ls_drug_time are now added to the variable list.
- liver stage drug was not differentiated from blood stage drug, so there was some confusion in subsetting and outputs in calculate_successful_treatments function.
1. ls_drug and ls_drug_time are now added to the variable list. 2. ls drug was not differentiated from bs drug, so there was some confusion in subsetting and outputs in calculate_successful_treatments function.
RJSheppard
force-pushed
the
vivax_treatment_prophylaxis_fix
branch
from
d4138d9 to
57bba5e
Compare
pwinskill
approved these changes
Mar 24, 2025
| @@ -338,7 +338,9 @@ create_variables <- function(parameters) { | |||
| last_boosted_iaa = last_boosted_iaa, | |||
| iaa = iaa, | |||
| iam = iam, | |||
| hypnozoites = hypnozoites | |||
| hypnozoites = hypnozoites, | |||
| ls_drug = ls_drug, | |||
There was a problem hiding this comment.
Just a note that in the description (lines 38 and 39) it would be worth stating that these a "liver-stage"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.