Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrc-4333 e2e tests #179
mrc-4333 e2e tests #179
Changes from 1 commit
d9030c4
401f806
f4c8cee
44810f1
999dfc1
858c3b7
1b70507
47b2c73
9110d07
24d37e7
f96ff73
65e5a64
5fb99dc
d1fc962
a433d1d
78b79cd
51c7f14
131f07e
45ed78f
b659293
c33c16e
46c86a1
72c2ae9
65470ce
f88ea33
42fa7b9
a8452ed
09c2362
7f14adb
fe74641
011e99b
929c9d4
688b118
47a41f4
a0a15ca
73a855a
2d6b370
373fa3c
831f778
1652e88
19472a7
c59b700
caf28a0
66a606f
746c90c
cf9be0b
d168b21
005330f
df25e94
15dee7e
ef187e3
a2d8065
12dbc8f
63c64f1
da88cfd
7cb2e42
ed09eb4
0eb3b65
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would these be useful to upload as artefacts of the CI?
eg.
packit/.github/workflows/backend-test-and-build.yml
Lines 72 to 81 in 377f8e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that
auth.json
is written to thetest-results
dir, so if that is erroneously not deleted (e.g. if playwright dies mid-run), we'd be uploading the github access token for all to see. Soauth.json
might want to be written somewhere else instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wouldn't be the github access token, it would just be the temporary packit token, which would only apply to the localhost instance we're running on CI, so I think we should be ok unless we start running tests against prod on CI. I'll try to omit the auth.json though. (Playwright doesn't let you write outside the parent folder, but I'll try deleting it before upload.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.