Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template/update #133

Draft
wants to merge 28 commits into
base: develop
Choose a base branch
from
Draft

Template/update #133

wants to merge 28 commits into from

Conversation

anoronh4
Copy link
Collaborator

@anoronh4 anoronh4 commented Jan 8, 2025

Pipeline template update

Some well overdue pipeline template updates. Because there hasn't been a sync in so long i had to follow the sync retrospectively guide, but now that we are in sync we should in the future be able to follow the manual sync guide, provided we don't wait too long between updates.

Some highlights in the update:

  1. pipeline initialization has been structured differently as a subworkflow rather than groovy library methods. prints version info, summarizes and dumps pipeline parameters, validates parameters, and now reads in and validates the input samplesheet.
  2. The fastq samplesheet is now validated using nf-schema and the definition file assets/schema_input.json. The maf input file is also now validated using nf-schema using a separate definition file assets/schema_maf_input.json.
  3. software dump prints to a different file in the same location and pipeline template now has different logic for generating it.
  4. pipeline completion workflow added, which sends emails upon completion or failure.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the mskcc/forte branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@anoronh4 anoronh4 marked this pull request as draft January 8, 2025 04:34
@anoronh4 anoronh4 requested a review from gongyixiao January 10, 2025 22:59
@anoronh4
Copy link
Collaborator Author

it might make sense to create a new branch off of develop called dev and use that instead. the template wants dev and our code keeps getting incongruous because i for some reason chose develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant