Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ re #63 ] Namespaces induce localenvs for their non-ambiguous names #76

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[ re #63 ] Namespaces induce localenvs for their non-ambiguous names #76

wants to merge 7 commits into from

Conversation

gallais
Copy link
Member

@gallais gallais commented May 7, 2020

Still missing:

  • Javascript implementation

hint-man[bot]
hint-man bot reviewed May 7, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why your PR is still not approved? Because I chose not to approve it. But they will.

gallais and others added 4 commits May 7, 2020 21:18
@gallais @hint-man
Update src/Shonkier/Traversal.hs
bbd63cc 
Co-authored-by: hint-man[bot] <44720633+hint-man[bot]@users.noreply.github.com>
@gallais
[ debatable ] abort for empty namespaces
007af7b
@gallais
[ more ] encode Namespace into js
b59b61c 
Stuck waiting for the js refactoring for the rest of the feature.
@gallais
Merge branch 'master' into ns-context
4d47831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gallais