Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connections over SSH #1447

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Support connections over SSH #1447

wants to merge 6 commits into from

Conversation

d-mato
Copy link

@d-mato d-mato commented Mar 2, 2025

This pull request introduces SSH tunneling support for multiple database drivers and updates various configuration files accordingly. The main updates include adding SSH configuration options, modifying the connection logic to support SSH tunneling, and updating the build scripts.

SSH Tunneling Support:

Drivers Updates:

  • Modified connection logic to support SSH tunneling.
  • Added ssh connection options to connection.schema.json and ui.schema.json.
image

Build Script Updates:

Due to the installation of tunnel-ssh, an error occurred ("No loader is configured for ".node" files"). To resolve this issue, the esbuild options were updated by adding the --loader:.node=file flag.

Related issues


  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have written a description of what is the purpose of this pull request above

@bogdan-velicu
Copy link

We need this added, looks good 👍

@Vic020
Copy link

Vic020 commented Mar 16, 2025

Great job! Hope this PR gets merged ASAP 👍

@d-mato
Copy link
Author

d-mato commented Mar 16, 2025

The CI tests are failing. It seems that I need to update the version of packages. However, I'm not sure if I should proceed with the update.

I need some help!

@gjsjohnmurray
Copy link
Collaborator

@d-mato I think this needs to be split into two PRs. The first one should contain your existing packages/base-driver changes but also bump the version of its package.json to 0.2.0

After we merge this and publish the new @sqltools/base-driver to npmjs.com I think your second PR will be able to complete its CI.

@gjsjohnmurray
Copy link
Collaborator

@d-mato when preparing the base-driver PR please also add an entry to its CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants