Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add notistack demo to the snackbar page #13685

Merged
merged 4 commits into from
Nov 27, 2018
Merged

[docs] Add notistack demo to the snackbar page #13685

merged 4 commits into from
Nov 27, 2018

Conversation

iamhosseindhv
Copy link
Contributor

Following up this issue, I have added a simple example of notistack to Snackbar documentation page.

However, this PR is not fully functional since notistack needs @material-ui/core as a peer dependency. So I wanted to make sure if I can add @material-ui/core as a devDependency to package.json ?

Thanks.

@iamhosseindhv iamhosseindhv changed the title [docs] Add notistack live deme to Snackbar documentation page [docs] Add notistack live demo to Snackbar documentation page Nov 25, 2018
@joshwooding
Copy link
Member

joshwooding commented Nov 25, 2018

There is some guidance here on solving the peer dependency issue: #13659 (comment) :)

@iamhosseindhv
Copy link
Contributor Author

Thanks @joshwooding. The issue is fixed now and live demo is working. ❤️

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: tooltip This is the name of the generic UI component, not the React module! labels Nov 27, 2018
@oliviertassinari oliviertassinari changed the title [docs] Add notistack live demo to Snackbar documentation page [docs] Add notistack demo to the snackbar page Nov 27, 2018
@oliviertassinari oliviertassinari merged commit 8f31edc into mui:master Nov 27, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 27, 2018

@iamhosseindhv Thank you, keep up the good work with this project :).

@iamhosseindhv
Copy link
Contributor Author

Thanks @oliviertassinari. So great to have a demo on the official website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants