-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Migrate CssBaseline to react-testing-library #22920
[test] Migrate CssBaseline to react-testing-library #22920
Conversation
No bundle size changes comparing cb6b69b...1007f2f |
I'm trying to figure out what is the connection between this component and
I will appreciate any guideness here. |
@eladmotola let us know if you can find the origin of the issue :). Otherwise, I think that we can close and solve it at a future point in time, where the enzyme test is becoming a blocker for an improvement we want to ship. |
@oliviertassinari My hunch was right and it was indeed the "strict:false" here.... so its ready to be merged :) |
Oh nice, @eps1lon is going to like this one. We have already seen something similar in the past: #18018. I would suspect that in strict mode, the cleanup isn't behaving as expected, we are left with a side effect in the page, which breaks, later on, the swipeable drawer test. I think that we can merge 👌 |
Yep, it's described above: https://github.com/mui-org/material-ui/blob/60d99a39836fb82f4da1477a717f642c216fb0b9/packages/material-ui/src/CssBaseline/CssBaseline.test.js#L7-L8 |
#22911