[test] Migrate Accordion to react-testing-library #22952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 5af951b...e40ee39 |
oliviertassinari
changed the title
46 tasks
oliviertassinari
added
the
component: accordion
joshwooding
previously requested changes
Oct 10, 2020
oliviertassinari
approved these changes
Oct 10, 2020
joshwooding
approved these changes
Oct 10, 2020
|
Thanks @bewong89 🎉 It's a great first contribution to Material-UI :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok second try! I followed the assertion patterns from the examples more closely this time and didn't touch the
describeConformancetest as the direction for them seems unknown at this point.#22911