[test] Convert NativeSelectInput tests to testing-library #26952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jun 25, 2021
| @@ -4,7 +4,7 @@ import { Theme } from '..'; | |||
|
|
|||
| export interface NativeSelectInputProps extends React.SelectHTMLAttributes<HTMLSelectElement> { | |||
| disabled?: boolean; | |||
| IconComponent?: React.ElementType; | |||
| IconComponent: React.ElementType; | |||
There was a problem hiding this comment.
Drive-by change. The prop types aren't auto generated so this slipped through.
eps1lon
changed the title
eps1lon
force-pushed
the
test/NativeSelectInput/testing-library
branch
from
445d3a6 to
b978454
Compare
github-actions
bot
added
the
PR: out-of-date
eps1lon
force-pushed
the
test/NativeSelectInput/testing-library
branch
from
b978454 to
6d7fcdf
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #26949 (diff)
Part of #22911
Last tests where we can switch from enzyme. The remaining test need enzyme. Not converting the JSS tests since I consider them legacy at this point and don't want them to block React 18 efforts in case JSS has issues with concurrent rendering.