Allow more systemd-resovled config paths #2065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
pinkisemils
force-pushed
the
linux-fix-systemd-resolved
branch
from
9f20346 to
64c1e89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1968, I removed the non-stub systemd-resolved config paths, as there can be issues if there are more than 3 DNS server entries set. This isn't actually ideal, as then the daemon will fall back to using resolvconf, and our DNS servers will not be used at all. Since it takes active effort on the users part to add extra DNS entries to their config to break the behavior I'm introducing in this PR, but a default install will fail on master, I'm adding back the stub config paths back. I have confirmed that this fix works on Debian testing.
This change is