Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix full-disk access check getting stuck #7326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix full-disk access check getting stuck #7326

wants to merge 1 commit into from
+14 −10

Conversation

dlon
Copy link
Member

@dlon dlon commented Dec 11, 2024 •
edited by faern
Loading

The full-disk access check can get stuck when there's no output from eslogger, and not timeout correctly. This was due to an incorrect else branch in tokio::select!.

Fix DES-1452.

This change is Reviewable

@linear Linear
Copy link

linear bot commented Dec 11, 2024

DES-1452 Split-tunneling full-disk-access check takes very long

@dlon dlon force-pushed the macos-fix-eslogger-timeout branch from baac372 to 24e0d74 Compare December 11, 2024 13:23
@dlon dlon requested a review from hulthe December 11, 2024 13:23
@dlon dlon added the Daemon Issues related to mullvad-daemon label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulthe hulthe Awaiting requested review from hulthe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Daemon Issues related to mullvad-daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlon