Fix camera behavior and getCameraMatrix return values (#1282 & #1284)
#4393
+114
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tederis
added
backwards-incompatible
FileEX
requested changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1282 by reading the actual rendering FOV instead of using the individual camera instance, and addresses #1284 by returning the interpolated matrix instead of the target matrix during transitions.
getCameraMatrix()now reports FOV values (including Roll) that match the actual rendering, and the camera matrix during vehicle entry is smooth and accurate. However, on vehicle exit there is a ~1 second delay (still better than the current behavior), which seems consistent with normal game behavior (until now i see it's maybe not a bug due to directional timing differences and different interpolation fractions between entering and exiting a vehicle, try to reproduce #1284 with the script in same issue to understand what i mean .. I can provide a comparison video later). I don’t consider this a bug, though replacing the hooks might eliminate the delay entirely (so hard to refactor camera behavior :D)It also removes server-side restrictions to ensure
getCameraMatrix()works correctly across all camera states.