-
Notifications
You must be signed in to change notification settings - Fork 8
Fixes and refactors #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I realized that it may be necessary (I've already added it to the function schema) to have an optional property to specify whether the function has optional parameters. |
Add 'important notes' property to function schema and update notes display. Refactor style on pages
…n on functions page
Thank you for having done the funcPair / fix. If you remove the other changes you made I can accept this PR. Also, we need to "build" the syntax of functions to display it. It's a bit complex because you need to consider several cases: client only functions, server only functions, shared only functions that can have a shared syntax OR a different syntax for client/server if either a parameter is different or a return value is different. |
Please resolve conflicts @Lettify |
Providing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
Build failed. You forgot to update the rest of the functions' notes. |
This pull request includes a small change to the
web/src/pages/[func].astro
file. It updates thefuncPair
link to prepend a forward slash (/
), ensuring the link resolves correctly as a relative path.In the previous code, when clicking on the pair function, the user was redirected to a non-existent page but the URL was displayed as a page relative to the current page where the user was.
For example, I was on the
/setElementHealth
page, when I tried to access the pair function I went to/setElementHealth/getElementHealth
.