Skip to content

Fixes and refactors #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 20, 2025
Merged

Fixes and refactors #9

merged 16 commits into from
May 20, 2025

Conversation

Lettify
Copy link
Contributor

@Lettify Lettify commented May 5, 2025

This pull request includes a small change to the web/src/pages/[func].astro file. It updates the funcPair link to prepend a forward slash (/), ensuring the link resolves correctly as a relative path.

In the previous code, when clicking on the pair function, the user was redirected to a non-existent page but the URL was displayed as a page relative to the current page where the user was.

For example, I was on the /setElementHealth page, when I tried to access the pair function I went to /setElementHealth/getElementHealth.

@Lettify
Copy link
Contributor Author

Lettify commented May 5, 2025

I realized that it may be necessary (I've already added it to the function schema) to have an optional property to specify whether the function has optional parameters.

@Lettify Lettify changed the title Fix pair redirect Fixes and refactors May 5, 2025
@Fernando-A-Rocha
Copy link
Collaborator

Fernando-A-Rocha commented May 19, 2025

Thank you for having done the funcPair / fix. If you remove the other changes you made I can accept this PR.

Also, we need to "build" the syntax of functions to display it. It's a bit complex because you need to consider several cases: client only functions, server only functions, shared only functions that can have a shared syntax OR a different syntax for client/server if either a parameter is different or a return value is different.
@Lettify

@Nico8340
Copy link
Collaborator

Please resolve conflicts @Lettify

@Lettify
Copy link
Contributor Author

Lettify commented May 19, 2025

Please resolve conflicts @Lettify

Providing that

@Lettify Lettify requested a review from Fernando-A-Rocha May 19, 2025 21:17
@Lettify Lettify requested a review from Fernando-A-Rocha May 20, 2025 00:11
Copy link
Collaborator

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@Nico8340 Nico8340 merged commit 1989e0f into multitheftauto:main May 20, 2025
1 check passed
@Lettify Lettify deleted the docs/new-pages branch May 20, 2025 01:45
@Lettify Lettify restored the docs/new-pages branch May 20, 2025 01:45
@Lettify Lettify deleted the docs/new-pages branch May 20, 2025 01:45
@Fernando-A-Rocha
Copy link
Collaborator

Fernando-A-Rocha commented May 20, 2025

Build failed. You forgot to update the rest of the functions' notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants