Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not modify property names #4

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Conversation

zi
Copy link
Member

@zi zi commented Feb 25, 2021

Previuosly, when a property name contained the character "-" it converted the name to camel case.
Now all the property name are strings and remain unchanged

Previuosly, when a property name contained the character "-" it converted the name to camel case.
Now all the property name are strings and remain unchanged
@zi zi requested a review from toomuchdesign February 25, 2021 13:32
@toomuchdesign
Copy link

Hi @zi,
do we any test covering the specific change introduced by this PR or since we're just bringing back a default behaviour there's no need of it?

PS.
Unfortunately I was quite disoriented by fp-ts methods, I have no clue what they do and the docs were not reassuring :)

@zi
Copy link
Member Author

zi commented Feb 25, 2021

do we any test covering the specific change introduced by this PR or since we're just bringing back a default behaviour there's no need of it?

hi @toomuchdesign, yes, that's exactly the case. It's the default behaviour so it's covered by the current tests, i've updated them.
I removed a test that covered a special case in which we were using this behaviour

Copy link

@toomuchdesign toomuchdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the full picture, but the bits I could understand looked good to me 👍

@zi zi merged commit 6311213 into master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants