13679: Focus and accessibility improvements of Spin edit controls

musescore · Feb 23, 2025 · 8dcfb2b · 8dcfb2b
1 parent 9033dc2
commit 8dcfb2b
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 3 deletions.
diff --git a/src/framework/accessibility/iaccessible.h b/src/framework/accessibility/iaccessible.h
@@ -55,6 +55,7 @@ class IAccessible
         List,
         ListItem,
         MenuItem,
+        SpinBox,
         Range,
         Group,
 

diff --git a/src/framework/accessibility/internal/accessibleiteminterface.cpp b/src/framework/accessibility/internal/accessibleiteminterface.cpp
@@ -192,6 +192,10 @@ QAccessible::State AccessibleItemInterface::state() const
         state.focusable = true;
         state.focused = item->accessibleState(IAccessible::State::Focused);
     } break;
+    case IAccessible::Role::SpinBox: {
+        state.focusable = true;
+        state.focused = item->accessibleState(IAccessible::State::Focused);
+    } break;
     case IAccessible::Role::Range: {
         state.focusable = true;
         state.focused = item->accessibleState(IAccessible::State::Focused);
@@ -225,6 +229,7 @@ QAccessible::Role AccessibleItemInterface::role() const
     case IAccessible::Role::List: return QAccessible::List;
     case IAccessible::Role::ListItem: return QAccessible::ListItem;
     case IAccessible::Role::MenuItem: return QAccessible::MenuItem;
+    case IAccessible::Role::SpinBox: return QAccessible::SpinBox;
     case IAccessible::Role::Range: return QAccessible::Slider;
     case IAccessible::Role::Group:
     case IAccessible::Role::Information:

diff --git a/src/framework/ui/view/qmlaccessible.h b/src/framework/ui/view/qmlaccessible.h
@@ -59,8 +59,11 @@ class MUAccessible
         List,
         ListItem,
         MenuItem,
+        SpinBox,
         Range,
-        Information
+        Group,
+        Information,
+        ElementOnScore
     };
     Q_ENUM(Role)
 };

diff --git a/src/framework/uicomponents/qml/Muse/UiComponents/IncrementalPropertyControl.qml b/src/framework/uicomponents/qml/Muse/UiComponents/IncrementalPropertyControl.qml
@@ -148,14 +148,21 @@ Item {
         anchors.top: parent.top
         anchors.bottom: parent.bottom
 
+        navigation.accessible.role: MUAccessible.SpinBox
         navigation.onNavigationEvent: function(event) {
+            if (!textInputField.activeFocus) {
+                return
+            }
+
             switch (event.type) {
             case NavigationEvent.Up:
                 root.increment()
+                selectAll()
                 event.accepted = true
                 break
             case NavigationEvent.Down:
                 root.decrement()
+                selectAll()
                 event.accepted = true
                 break
             }
@@ -191,8 +198,8 @@ Item {
             canIncrease: root.canIncrease
             canDecrease: root.canDecrease
 
-            onIncreaseButtonClicked: { root.increment() }
-            onDecreaseButtonClicked: { root.decrement() }
+            onIncreaseButtonClicked: { root.increment(); textInputField.selectAll() }
+            onDecreaseButtonClicked: { root.decrement(); textInputField.selectAll() }
         }
 
         mouseArea.onWheel: function(wheel) {

diff --git a/src/framework/uicomponents/qml/Muse/UiComponents/TextInputField.qml b/src/framework/uicomponents/qml/Muse/UiComponents/TextInputField.qml
@@ -117,6 +117,8 @@ FocusScope {
                 root.ensureActiveFocus()
             }
         }
+
+        onTriggered: root.ensureActiveFocus()
     }
 
     Rectangle {
@@ -191,6 +193,10 @@ FocusScope {
                     return
                 }
 
+                if (event.key === Qt.Key_Up || event.key === Qt.Key_Down) {
+                    return;
+                }
+
                 if (textInputModel.isShortcutAllowedOverride(event.key, event.modifiers)) {
                     event.accepted = true
                 } else {
-Original file line number
+Diff line change
@@ Expand Up / @@ -55,6 +55,7 @@ class IAccessible @@
             List,
             ListItem,
             MenuItem,
+            SpinBox,
             Range,
             Group,
@@ Expand Down @@